search

SENSEI-insitu / SENSEI

SENSEI ∙ Scalable in situ analysis and visualization
https://sensei-insitu.org
Other
22 stars 21 forks source link

sVTK HAMR data array #101

Closed burlen closed 1 year ago

burlen commented 1 year ago

@ghweber

burlen commented 1 year ago

@kwryankrattiger Trying to get the ecp CI to run on this PR. A couple changes are needed 1. we need to update git submodules before the build. 2. during testing we need the PYTHONPATH set. For the first, I tried to initialize the sub mods directly but got an unexpected error (only in the ecp ci, see below). For the second we already generate a shell script to do this, we only need to source it before running the tests. I'm sure I could hack this stuff in, and I'm also sure that what I would do will not be the best way to get it to work in your system. Could you help on this? Feel free to push a commit here as this is the last thing before I merge this branch.

Run git submodule update --init --recursive
fatal: detected dubious ownership in repository at '/__w/SENSEI/SENSEI'
To add an exception for this directory, call:

    git config --global --add safe.directory /__w/SENSEI/SENSEI
Error: Process completed with exit code 12[8](https://github.com/SENSEI-insitu/SENSEI/actions/runs/5729614012/job/15526695629?pr=101#step:5:9).
burlen commented 1 year ago

@kwryankrattiger I tried your suggestion and our submodules got set up correctly. Unfortunately this caused some interaction with pugixml. SENSEI no longer finds it, and I see that the ecp ci uses an external install. Any ideas about this? Is it the case that the ecp ci clones pugixml into the sensei checkout?

burlen commented 1 year ago

@kwryankrattiger all set. turns out after your hint worked all the other issues were due to changes I made. I had play catch up. It's all set now.

danlipsa commented 1 year ago

@burlen utils/HAMR directory is empty. Did you forget to add those files to the project? This is on the develop branch.

danlipsa commented 1 year ago

A git submodule init/update fixed it. Just ignore my previous comment.