search

SERG-Delft / jpacman-template

Template to start working on a solution for JPacman software testing exercises.
2 stars 10 forks source link

Fix PMD configuration for JUnit 5 #31

Open jwgmeligmeyling opened 7 years ago

jwgmeligmeyling commented 7 years ago

Since the migration to JUnit 5, the warnings generated for JUnit by PMD do not make any sense anymore. Besides the default JUnit rules provided by PMD (1 and 2, we also included one of our own PMD-rules to warn students for invalidly catching exceptions in tests.

It is very important that we for now disable the JUnit PMD config unless we have rewritten the PMD rules to JUnit 5. I think hardly any of the generated JUnit rules will make sense. Ideally we rewrite the PMD ruleset for JUnit 5 and merge it back in to the templates later on.

avandeursen commented 7 years ago

Yes, you are right. I had done this for the framework, but forgot to do this for the template.

Just copying the framework's pmd config file to the template would have worked too.