search

SFML / imgui-sfml

Dear ImGui backend for use with SFML
MIT License
1.08k stars 163 forks source link

sfml-imgui works improperly with recent sfml updates #280

Closed gameoflord012 closed 1 month ago

gameoflord012 commented 1 month ago

I tried to integrate sfml-imgui with recent sfml version and it broke

The main reason is Cursor::Cursor() become private in this issue https://github.com/SFML/SFML/pull/3028 Cause declaring array in imgui-SFML.cpp:194 is invalid

sf::Cursor mouseCursors[ImGuiMouseCursor_COUNT];

Also changing loadFromSystem from bool to std::optional in return type causing type conversion error at imgui-SFML.cpp:1068

s_currWindowCtx->mouseCursorLoaded[imguiCursorType] =
        s_currWindowCtx->mouseCursors[imguiCursorType].loadFromSystem(sfmlCursorType);
ChrisThrasher commented 1 month ago

See https://github.com/SFML/imgui-sfml/pull/281