SFU-Blueprint / Pedals

Apache License 2.0
0 stars 0 forks source link

/manage/people Feedback component overlay bug #79

Closed terry9041 closed 5 days ago

terry9041 commented 1 week ago

Problem

After clicking "confirm" button of the Popup component from 1) removing ppl from db or 2) editing people info, the Feedback component shows that the app is loading. But it is under the overlay of the Popup component

Expected Design

It should be shown above the overlay of the Popup Component

Instructions

  1. Pull the latest changes from the develop branch.
  2. Start the server by running npm run dev (if necessary, navigate to the src/ folder and run npm ci first). Navigate to localhost:3000/manage/people
  3. Modify the code of Popup.tsx, Feedback.tsx and page.tsx file for manage/page to modify the z-index related code, restructuring maybe needed
  4. Check for this issue on other pages too, where Popup and Feedback component could be on the screen at the same time (eg /manage/shift). Make an issue for that if the bug persists after this fix
  5. Submit a pull request and tag @dangminhduc1101 for review.