Investigate current i2c to PWM 16-channel driver

SJSURoboticsTeam / urc-central-2021

Track progress and information for the URC 2021 competition

MIT License

1 stars 0 forks source link

Investigate current i2c to PWM 16-channel driver #227

Closed jram-git0 closed 2 years ago

jram-git0 commented 2 years ago

Thank you @naterpotatoers for the reference: https://github.com/SJSURoboticsTeam/urc-control_systems-2021/blob/master/Arm/Hand/pca9685.hpp and credits to @AndrewDEmerson for working on this.. I think this could be .hpp file in the Common folder or maybe even in the SJSU-Dev2 code?

kammce commented 2 years ago

The title of this issue is to make an driver for the pca9685 (the i2c to 16 channel pwm device). But the first comment references an already existing implementation. What is the purpose of this bug?

jram-git0 commented 2 years ago

Hey Khalil, whoops! I probably made a mistake or there was miscommunication.. I thought this still needed to be fully implemented/tested but if it's already finished then we could close this one out.

kammce commented 2 years ago

You should list in the first comment exactly what needs to be done so its clear what is needed. Also change the title to reflect the intent of this issue.

jram-git0 commented 2 years ago

Thank you for the tips! I haven't looked into the code fully but wanted to create this issue if it isn't fully implemented. I'll make the changes soon unless anyone wants to edit it. I didn't assign myself yet