check that requested cores >= 1 and < node core total

SMART-Lab / smartdispatch

An easy to use job launcher for supercomputers with PBS compatible job manager.

Do What The F*ck You Want To Public License

34 stars 18 forks source link

check that requested cores >= 1 and < node core total #136

Closed slefrancois closed 8 years ago

slefrancois commented 8 years ago

Fixes #92

coveralls commented 8 years ago

Coverage remained the same at 94.306% when pulling d782bfc2f921d740575657cc4c98d74e0ea65e91 on slefrancois:warn_core_over into 4e38f34d87d86cda6a40403243cd8fbb2d7711e6 on SMART-Lab:master.

MarcCote commented 8 years ago

Can you make unit tests to check your fix?

mgermain commented 8 years ago

Yup just add some tests in test_smart_dispatch.py and I'm good with merging this.

coveralls commented 8 years ago

Coverage increased (+0.04%) to 94.341% when pulling 8a9ce7f12830b5fc50c5248f120857b2b3d336f0 on slefrancois:warn_core_over into 4e38f34d87d86cda6a40403243cd8fbb2d7711e6 on SMART-Lab:master.

MarcCote commented 8 years ago

LGTM