Refactored optimizer to easily access the gradients and the directions

SMART-Lab / smartlearner

SMART-Learner is a machine learning library built with researchers in mind.

BSD 3-Clause "New" or "Revised" License

10 stars 4 forks source link

Refactored optimizer to easily access the gradients and the directions #31

Closed MarcCote closed 9 years ago

MarcCote commented 9 years ago

This PR is mainly a small refactoring of the classes Optimizer and Loss. In bonus, it adds a new optimizer ADAGRAD and some integration tests for both SGD and ADAGRADoptimizers.

Closes #34

ASalvail commented 9 years ago

A module named modifier seems awfully undescriptive... direction_modifiers?

MarcCote commented 9 years ago

I agree it is very undescriptive but it also contains param_modifier not only direction_modifier.

ASalvail commented 9 years ago

AFAIK, there's no param_modifier yet, right? If that's the case, we could have a second directory to store the param_modifier eventually.