search

SMART-Lab / smartlearner

SMART-Learner is a machine learning library built with researchers in mind.
BSD 3-Clause "New" or "Revised" License
10 stars 4 forks source link

Logger #49

Closed ASalvail closed 9 years ago

ASalvail commented 9 years ago

The new task fixes #50 . However, in the test, we still talk with the view instead of the task. What would you suggest to make the logging interface better? I agress that logger[0][0] is a bit klunky...

ASalvail commented 9 years ago

Klunky calls are fixed (partially) in 4fa113159a16474f204f9880664ff1afeb71cdef.

MarcCote commented 9 years ago

@ASalvail what do you mean by partially? You mean the logger is still klunky? We could add a test in Logger and if there is only one view, do not return tuple but return a single value instead.

ASalvail commented 9 years ago

The problem with this is that now the interface would be different depending on the call. Can we use a starred tuple as a return argument? ie return *self._history

MarcCote commented 9 years ago

Ah yes, I hadn't thought of that.

MarcCote commented 9 years ago

I don't have any more comments, is this ready to merge?

ASalvail commented 9 years ago

Now it is.

MarcCote commented 9 years ago

Oups, should I'd merged this PR before #51 ? Can you rebase master and I'll merge it.

ASalvail commented 9 years ago

Both were based on master. The rebase and some corrections are done.