Too many Association requests issued over short period of time

SMI / RdmpDicom

Plugin for RDMP that adds support for load, linking (with EHR data in relational databases) and extracting anonymous DICOM images for researchers.

GNU General Public License v3.0

4 stars 4 forks source link

Too many Association requests issued over short period of time #155

Open tznind opened 3 years ago

tznind commented 3 years ago

Describe the bug The Hic device was attempting to associate with PACS and failing multiple times per second. This cumulative effect filled up the available Philips PACS Services and we were no longer able to accept any dicom requests

Expected behavior System should log when associations are initiated or closed and detect when multiple associations are made over a short period of time. In such circumstance the system should shut down or enter a sleep mode until the problem is resolved.

jas88 commented 3 years ago

This issue might be relevant - seems to be a corner case where fo-dicom gets a TCP connection but doesn't get connected properly, so retries repeatedly in a loop? They reproduced it by trying to talk to Google as a PACS: it accepts the connection, but of course doesn't speak DICOM, so that stage fails - and gets retried repeatedly. https://github.com/fo-dicom/fo-dicom/issues/933

amoerie commented 2 years ago

Hi, fo-dicom contributor here, I saw you guys linking to one of our issues. You might be interested in https://github.com/fo-dicom/fo-dicom/pull/1285. Cheers!

tznind commented 2 years ago

Thanks for the heads up about the PR @amoerie. Being able to handle association request timeout as well as accepted/rejected should be helpful. At the very least we can add it into the count managed by our (rather brutal) MaximumAllowableAssociationEventsPerMinute setting in our tool.