[joss review] JOSS manuscript

SMTG-Bham / ThermoParser

A tool for streamlining data analysis and visualisation for thermoelectrics and charge carrier transport in computational materials science.

https://smtg-bham.github.io/ThermoParser/

GNU Affero General Public License v3.0

47 stars 15 forks source link

[joss review] JOSS manuscript #83

Closed fnattino closed 8 months ago

fnattino commented 8 months ago

Just a couple of minor comments on the manuscript:

The link to the gallery is broken (line 77), it points to an old repository?
In the ThermoParser section, you mention that the code lodes data into a common format with a meta directory, that includes metadata. But what is this general format and where is this directory created?

JOSS review issue

kbspooner commented 8 months ago

I have corrected the former, and the latter is mistyped, it should've said dictionary, which is a subdictionary in any data you load through tp, and this has now also been corrected.