SOA-01 / monolith-wanderwise

SOA 2024 UPSTART "Trip Planner"
0 stars 1 forks source link

DEVELOP 05: Domain Modeling #27

Open jerry914 opened 3 weeks ago

jerry914 commented 3 weeks ago

Task

I couldn't find your Heroku Web App URL in the Google Team Sheet. Please ensure your application is deployed online. Feel free to ask for assistance on Teams if you encounter any issues.

Robocop/Code Smell Offenses

N/A

Great progress so far—keep up the good work!

soumyaray commented 2 weeks ago

Please deploy your app to Heroku asap!

soumyaray commented 2 weeks ago

Big issue I think we should discuss: your entities currently don't have any interesting logic, which makes your app look like it just gets data from an API and shows it on screen (too easy an assignment for our class!). Let's please find a time to discuss what your main logic is and what/where it could be.

The two methods you have in your entities right now are not business logic, but rather more like presentation logic that belongs in view objects, because they simply represent the entities as strings on screen.

Arijus1979 commented 2 weeks ago

@soumyaray Hello, the app has been deployed https://wanderwise-5adb4693c491.herokuapp.com/

As for the logic. Currently, we only have some data analysis logic (historical flight price calculations).

For example, if we search for a flight from LAX to TPE, we save the information to our database for later analysis. For example, we can show the all-time lowest price and an average price for the selected flight.

Please let us know whether that is enough and what we could do to improve it.