search

SOF3 / await-generator

Write code in async/await style in PHP using generators.
https://sof3.github.io/await-generator/master/
Apache License 2.0
123 stars 15 forks source link

Pass resolved value to inner-next when fallback. #184

Closed Endermanbugzjfc closed 2 years ago

Endermanbugzjfc commented 2 years ago

My fork is so broken...

codecov[bot] commented 2 years ago

Codecov Report

Base: 99.42% // Head: 99.42% // No change to project coverage :thumbsup:

Coverage data is based on head (27fa383) compared to base (a6f328b). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #184 +/- ## ========================================= Coverage 99.42% 99.42% Complexity 127 127 ========================================= Files 10 10 Lines 345 345 ========================================= Hits 343 343 Misses 2 2 ``` | [Impacted Files](https://codecov.io/gh/SOF3/await-generator/pull/184?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jonathan+Chan+Kwan+Yin) | Coverage Δ | | |---|---|---| | [...it-generator/src/SOFe/AwaitGenerator/Traverser.php](https://codecov.io/gh/SOF3/await-generator/pull/184/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jonathan+Chan+Kwan+Yin#diff-YXdhaXQtZ2VuZXJhdG9yL3NyYy9TT0ZlL0F3YWl0R2VuZXJhdG9yL1RyYXZlcnNlci5waHA=) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jonathan+Chan+Kwan+Yin). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jonathan+Chan+Kwan+Yin)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Endermanbugzjfc commented 2 years ago

Succeeded test: https://github.com/Endermanbugzjfc/FormInteractionFix/actions/runs/3404951846/jobs/5662566002

Endermanbugzjfc commented 2 years ago

Please do not forget to bump version number and create release tag, thanks.

SOF3 commented 2 years ago

can you add unit tests to show what this has fixed?

Endermanbugzjfc commented 2 years ago

can you add unit tests to show what this has fixed?

In await-generator?

SOF3 commented 2 years ago

can you add unit tests to show what this has fixed?

In await-generator?

yes, bug fixes should also include a unit test case that used to fail but no longer fails

Endermanbugzjfc commented 2 years ago

can you add unit tests to show what this has fixed?

In await-generator?

yes, bug fixes should also include a unit test case that used to fail but no longer fails

Done.

SOF3 commented 2 years ago

Please do not forget to bump version number and create release tag, thanks.

will do tomorrow, please remind me if I forget