search

SOL-Space-Operating-Linux / meta-sol

Yocto layer for Space Operating Linux
MIT License
6 stars 1 forks source link

Is `tmr.diff` used at all? If so, where does it get applied to `tmr.c`? If not, can it be removed? #23

Closed pdlloyd closed 2 years ago

pdlloyd commented 2 years ago

There are a lot of significant modifications to common/tmr.c and common/main.c in recipes-bsp/u-boot/files/tmr.diff. However, recipes-bsp/u-boot/u-boot-tegra_%.bbappend, nor any other recipe, seems to apply this diff to the U-Boot sources.

My reasoning is that during boot, I get a message saying meta-sol ref 8e54ab013a4a34a8d5bf901e00131f3bf7581f30 which is consistent with the UGA-SSRL U-Boot fork that gets cloned in u-boot-tegra_%.bbappend. Conversely, the diffed source would print "meta-sol version 2.0".

Having this extra file that apparently doesn't do anything is pretty confusing. I'd like to remove it if it's no longer relevant.

pdlloyd commented 2 years ago

File removed with https://github.com/SOL-Space-Operating-Linux/meta-sol/pull/25