Devel Added new parameter USE_OTHER_TIME_FUNCTION

SPECFEM / specfem3d

SPECFEM3D_Cartesian simulates acoustic (fluid), elastic (solid), coupled acoustic/elastic, poroelastic or seismic wave propagation in any type of conforming mesh of hexahedra (structured or not).

GNU General Public License v3.0

389 stars 223 forks source link

Devel Added new parameter USE_OTHER_TIME_FUNCTION #1691

Closed homnath closed 2 months ago

homnath commented 2 months ago

Added Brune and Smoothed Brune source time function for CMTSOLUTION via new parameter USE_OTHER_TIME_FUNCTION.

homnath commented 2 months ago

I think it is unrelated to my change but it failing at testing Example 4 which runs fine on my part!

danielpeter commented 2 months ago

maybe an issue with array allocation and array size when receivers become (adjoint) sources in pure adjoint simulations...

some suggestions:

rename the USE_OTHER_TIME_FUNCTION to USE_BRUNE_TIME_FUNCTION? for now, this flag seems to turn on a feature specific for Brune-type STFs, and no "other" STFs.
there is also a new test/ example in the EXAMPLES/applications/ folder. please rename it as well to give it a more specific meaning, the application title "test" is too general.

homnath commented 2 months ago

Thanks, Daniel! I will have a look 🙂

From: daniel peter @.> Sent: Thursday, April 25, 2024 9:11 AM To: SPECFEM/specfem3d @.> Cc: Hom Nath Gharti @.>; State change @.> Subject: Re: [SPECFEM/specfem3d] Devel Added new parameter USE_OTHER_TIME_FUNCTION (PR #1691)

maybe an issue with array allocation and array size when receivers become (adjoint) sources in pure adjoint simulations...

— Reply to this email directly, view it on GitHubhttps://github.com/SPECFEM/specfem3d/pull/1691#issuecomment-2077148057, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABMCQ4QHFTVUFVJDRR7INNTY7D6JXAVCNFSM6AAAAABGOG3C6GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZXGE2DQMBVG4. You are receiving this because you modified the open/close state.Message ID: @.***>