search

SRGSSR / srgletterbox-apple

The official SRG SSR media playback experience
https://srgssr.github.io/marketing/letterbox/
MIT License
14 stars 7 forks source link

Tapping "play/pause" button on remote control in background plays audio of already paused video #95

Open vpdn opened 7 years ago

vpdn commented 7 years ago

Issue overview

Description of the problem

When a user plays a video and leaves the app, the video stops and the player controls in control center are inactive (expected). If the user uses the play/pause button on a connected headphone however, the audio continues to play again. Controls in the control center are still inactive. This behaviour can be reproduced in the SRF App as well as the Play App.

Steps to reproduce

  1. Connect a headphone with remote control
  2. Open app and play a video
  3. Leave the app => Video stops.
  4. Press the "play/pause" button on the headphone's remote control

Current behaviour: Audio of the video plays in the background. The control center controls stay inactive.

Expected behaviour: Pressing the "play/pause" button on the remote control does nothing.

Environment information

Tested on iPhone 6 with iOS 11.1 and Samsung headphones as well as iPhone 7+ with iOS 11.0.3 with original Apple headphones.

Reproducibility

Check the correct option below

vpdn commented 7 years ago

This has been reported by our test team. I haven't tested it myself, but they managed to reproduce the behaviour on two different devices.

defagos commented 7 years ago

Definitely a bug, thanks for the report. We'll probably only be able to fix it in 1.6.1. I'll attach it to this milestone for the moment.

pyby commented 7 years ago

Our PO told us that it's not a major bug. We have to fix it, but also ask stakeholders about a feature: playing videos in background

defagos commented 7 years ago

Removed from 1.6.3 since no stakeholder discussion took place before this version is released.

vpdn commented 7 years ago

šŸ‘ŒšŸ¼ This is a minor issue imo, just wanted to report back what our testers found. As for playing videos in the background, that would be best discussed with the POs directly. Would make sense for consistency I think, but not sure how often users hit this case.