SRGSSR / srgmediaplayer-apple

An advanced media player library, simple and reliable
MIT License
158 stars 33 forks source link

iOS and tvOS 15 simulator issues #108

Open defagos opened 2 years ago

defagos commented 2 years ago

The iOS 15 and tvOS 15 simulator has a few issues which make some tests fail. Behavior is correct when the same behavior is tested on device, fortunately.

We should check if this issue is fixed in later versions or maybe report an issue to Apple.

Issue type

Other: Simulator bug

Description of the problem

Here are the tests which currently fail:

  1. -testOnDemandPlaybackStartAtTimeWithTolerances: Starting around a position fails in the simulator. This can also be verified by tweaking the SRG Media Player demo to start around some position (the player struggles to start). The same modified demo project run on device works fine, as does the UT in the iOS 14 simulator.
  2. -testStartTimeAroundBeginningOfSegmentWithSelection and -testStartTimeAroundEndOfSegmentWithSelection: Same issue due to position tolerances being used.

Environment information

Reproducibility

Always reproducible

Steps to reproduce

  1. Comment out the #warning lines in the source code.
  2. Run the unit tests in the iOS or tvOS 15 simulator.
defagos commented 2 years ago

When investigating UT issues in the iOS / tvOS 15.0 simulator I removed two tests that were testing readyForDisplay, failing with the iOS 15.0 simulator. These flags are best tested interactively IMHO, especially as we cannot run the tests on a device. With appropriate readyForDisplay logging in SRGMediaPlayerView I interactively checked for the flat view (AVPlayerView) as well as for the monoscopic / stereoscopic views that:

This is true whether the view is installed or not in a view hierarchy, as can be checked with the inline demo.

defagos commented 2 years ago

Not fixed in the 15.1 simulator.

defagos commented 2 years ago

Not fixed in the 15.2 beta 2 simulator.