search

SRGSSR / srgmediaplayer-apple

An advanced media player library, simple and reliable
MIT License
158 stars 33 forks source link

Forced subtitles #119

Closed defagos closed 2 years ago

defagos commented 2 years ago

The player currently does not support forced subtitles. Most notably:

defagos commented 2 years ago

Implemented on feature/forced-subtitles.

defagos commented 2 years ago

Example 1

Here are a few examples of how subtitles should be selected in the example of Apple advanced BipBop stream:

Use case 1

Setup:

Result:

Use case 2

Setup:

Result:

Example 2

Here are a few examples of how subtitles should be selected in the example of a stream containing the following tracks:

Use case 1

Setup:

Result:

Use case 2

Setup:

Result:

Use case 3

Setup:

Result:

Use case 4

Setup:

Result:

defagos commented 2 years ago

For SRGMediaPlayerViewController we cannot get a satisfying user experience, as the subtitles menu cannot be customized properly yet. There are allowedSubtitleOptionLanguages and requiresFullSubtitles properties, but those are too limited to implement something similar to our iOS settings UI.

Moreover, transportBarCustomMenuItems does not let built-in buttons be customized or removed, so we are stuck. We should likely make an improvement request via Feedback Assistant.