SSirMentos / pe

0 stars 0 forks source link

Consider merging same orders #4

Open SSirMentos opened 2 weeks ago

SSirMentos commented 2 weeks ago

Summary

Same orders with the same name and same delivery date does not add on to one another

Since the order have the same name and same delivery date, perhaps merge them together to make it more convienent for the user, as a customer might buy the same item repeatedly and might flood the entire addressbook

Steps to Reproduce

  1. addorder 1 i/Lamp d/20-12-2024 q/2 Execute repeatedly

Screenshots

image.png


Reasoning for Severity

With so much redudant details, it can cause a minor/occasional inconvenience for a user to continue using the addressbook

soc-pe-bot commented 1 week ago

Team's Response

We initially planned to allow users to keep track of orders separately, also because merging orders may lead to complications in terms of implementation and different orders (of the same details) may not always have the same circumstances (more details below).

Under the addorder command in the UG, the constraints state that a warning will be given if a pending order with a similar item and identical quantity and date already exists in the order list. image.png This implies that the app inherently accepts multiple separate orders of the same item with identical details.

Further, this app is considered from the perspective of a Carousell seller who may receive multiple orders from a single customer requesting for the same item, to be delivered by the same day. In this case, it is not necessary for the seller who may face limitations in delivering all of the orders in a single delivery, and may consider delivering them separately. Forcing the app to merge all of such orders may complicate order management for said partial deliveries.

However, we acknowledge that this can be better as we could have provided users with the option to merge orders, which can perhaps be in future implementations.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]