IME open model in iteration selection dialog - opening model as non-active domain should not be allowed

[MartinFijneman]

Prerequisites

• [x] I have written a descriptive issue title
• [x] I have verified that I am running the latest version of the CDP4-IME
• [x] I have searched open and closed issues to ensure it has not already been reported

Description

In specific testing situation it was possible to open a model representing a domain of expertise that was not an active domain. This happened in specific case given below in steps to reproduce, and using the direct opening of a model: double-clicking the model or click "Open" in the Iteration Selection dialog. This should not be allowed (as this may lead to confusion or subsequent problems related to ownership).

If the default domain is not an active domain in the engineering model, the user should be switched to the other selection dialog to choose a required domain.

Steps to Reproduce

• as user with all administrative rights, created a new engineering model from a source model ** NOTE: created testing model with person having "Data Handling" as default domain, based on existing source model without that domain
• logged in to the new model, directly opening in the iteration select dialog (double-click model or select model and click "Open")
• then apparently logged in as my default person domain DHS, which is not an active domain in the engineering model

this can then lead to problems:

• created element definition by drag-and-drop with a second (temporary exchange) model (dragged an existing element definition with parameters to exchange model and then back) problem: item (element definition with parameters) (power subsystem) is created for a domain that doesn't exist in the model.

Logs

• [x] There are no logs regarding the issue
• { ] I have attached a log file or included the relevant section in this issue

System Configuration

• CDP4 version:
  • [x] CDP4-IME: 7.0.0 RC3
  • [ ] Other:
• Web Services:
  • [ ] CDP4 Web Services version:
  • [ ] OCDT WSP version:
• Environment (Operating system, version and so on):
  • [ ] Microsoft Excel (32/64 bit):
  • [ ] Windows OS (32/64 bit):
  • [ ] Additional information:

[lxatstariongroup]

I have doubts on the correctness of the code in line 297 of the ExecuteSelectActiveIteration method in ModelOpeningDialogViewModel:

var defaultDomain = session.ActivePerson.DefaultDomain ?? activeIterationSetupRow.DomainOfExpertises.FirstOrDefault();

The defaultDomain variable is later used to read data from a session (session.Read(iteration, defaultDomain)). I think that the session.ActivePerson.DefaultDomain could be missing in a specific EngineeringModel, so this could be a wrong DomainOfExpertise for that EngineeringModel.

@samatrhea @MartinFijneman could this be the behaviour Martin experienced last week?