STMicroelectronics / STM32CubeH7

STM32Cube MCU Full Package for the STM32H7 series - (HAL + LL Drivers, CMSIS Core, CMSIS Device, MW libraries plus a set of Projects running on all boards provided by ST (Nucleo, Evaluation and Discovery Kits))
https://www.st.com/en/embedded-software/stm32cubeh7.html
Other
498 stars 305 forks source link

Fix: value of TEMPSENSOR_CAL2_TEMP depends on Rev (V vs. Y) #253

Closed peschuster closed 6 months ago

peschuster commented 1 year ago

According to the datasheet, the temperature for the second calibration value of the temperature sensor was changed from 110 °C to 130 °C with revision V of the STM32H7.

RJMSTM commented 1 year ago

Hello @peschuster

Thank you for your contribution. Would it be possible to share the reference of the datasheet.

BeST Regards, Rania

peschuster commented 1 year ago

Hello @RJMSTM

Thanks for taking care of this.

It is mentioned in the following datasheet: https://www.st.com/content/ccc/resource/technical/document/datasheet/group3/01/21/00/39/12/c9/4c/f1/DM00388325/files/DM00388325.pdf/jcr:content/translations/en.DM00388325.pdf

Section 6.3.23 is for revision Y and specifies TS_CAL2 to be the value for 110 °C (page 176). Section 7.3.23 is for revision V and specifies TS_CAL2 to be the value for 130 °C (page 288).

Unfortunately, this is not mentioned in the migration guide and was only brought to our attention after we opened a support case (see case 00171507).

I assumed all STM32H7 would have the same silicon, but after looking through the datasheets of other variants it looks like this fix might need further refinement to only affect certain STM32H7xxx variants.

RJMSTM commented 1 year ago

ST Internal Reference: 147066

ALABSTM commented 11 months ago

Hello @peschuster,

Thank you very much for having logged this issue and for this proposal. A fix has just been published here. It will be made available on this repository soon enough hopefully.

As you can see, our development teams preferred to implement the fix at the CMSIS level so that both HAL and LL ADC drivers could benefit from it.

Please allow me to close this pull-request in this case. Thank you again for your contribution and thank you for your comprehension.

With regards,

ALABSTM commented 10 months ago

Pull-request reopened as change at CMSIS interface's level reverted. The fix shall be implemented in a different way at the HAL-LL driver's level.

TOUNSTM commented 6 months ago

Fixed in abbf9ca1b36c9abdb9339e86f0b7b2f4e79edc35