search

SUSE / DeepSea

A collection of Salt files for deploying, managing and automating Ceph.
GNU General Public License v3.0
161 stars 75 forks source link

Use correct config name for Dashboard SSL port #1652

Closed votdev closed 5 years ago

votdev commented 5 years ago

Fixes: https://bugzilla.suse.com/show_bug.cgi?id=1129225

Signed-off-by: Volker Theile vtheile@suse.com

Checklist:

jschmid1 commented 5 years ago

@susebot run teuthology

susebot commented 5 years ago

Commit 75845ae614ffd68455e26a0791b52dd77fbc0773 is NOT OK for suite deepsea:tier2. Check tests results in the Jenkins job: http://storage-ci.suse.de:8080/job/pr-deepsea/194/

votdev commented 5 years ago

From the CI:

2019-05-10T11:32:36.393 INFO:teuthology.orchestra.run.target192168000062.stdout:[11/30] Executing state ceph.dashboard...
2019-05-10T11:32:38.021 INFO:teuthology.orchestra.run.target192168000062.stdout:         |_  target192168000062.teuthology: set dashboard ssl port(ceph config set mgr mgr/dashboard/ssl_server_port 8443) fail
2019-05-10T11:32:38.046 INFO:teuthology.orchestra.run.target192168000062.stdout:         target192168000062.teuthology... fail

Can not reproduce this locally in a SLE15 Vagrant cluster using DeepSea 0.9.18 via CLI or adapted SLS file.

[11/30]   ceph.dashboard on
          admin.ceph..................................................................... ✓ (2s)
            |_ cmd.run(ceph config set mgr mgr/dashboard/ssl_server_port 8443)........... ✓
            |_ cmd.run(ceph dashboard create-self-signed-cert)........................... ✓

admin:/home/vagrant # deepsea --version
deepsea 0.9.18+git.0.a21d7b040
admin:/home/vagrant # ceph config set mgr mgr/dashboard/ssl_server_port 8443
admin:/home/vagrant # echo $?
0

Any ideas?

jschmid1 commented 5 years ago

A bit further down the log:

 set dashboard ssl port: Command "ceph config set mgr mgr/dashboard/ssl_server_port 8443" run
 stdout:
 stderr: Error EINVAL: unrecognized config option 'mgr/dashboard/ssl_server_port' <---- this

I'd assume that the CI doesn't have an up-to-date ceph version.

ceph-mgr-14.2.0.300+gacd2f2b9e1-1.1.x86_64.rpm

What's your version @votdev ?

jschmid1 commented 5 years ago

@susebot run teuthology

susebot commented 5 years ago

Commit 1364b6819165919fe943786c3203a6729af487f5 is NOT OK for suite deepsea:tier2. Check tests results in the Jenkins job: http://storage-ci.suse.de:8080/job/pr-deepsea/197/

jschmid1 commented 5 years ago

same thing :/

votdev commented 5 years ago

A bit further down the log:

 set dashboard ssl port: Command "ceph config set mgr mgr/dashboard/ssl_server_port 8443" run
 stdout:
 stderr: Error EINVAL: unrecognized config option 'mgr/dashboard/ssl_server_port' <---- this

I'd assume that the CI doesn't have an up-to-date ceph version.

ceph-mgr-14.2.0.300+gacd2f2b9e1-1.1.x86_64.rpm

What's your version @votdev ?

ceph version 14.2.1-345-g040ffffe0e (040ffffe0e8b6db713d06fa487c2811b87884973) nautilus (stable)

votdev commented 5 years ago

OK, Ceph 14.2.1 is required, see http://tracker.ceph.com/issues/39001 for the feature that added this config setting.

I'm currently asking myself if it is necessary to check Ceph version now because for <= 14.2.0 the config option is server_port and for >= 14.2.1 it will be ssl_server_port.

jschmid1 commented 5 years ago

@kshtsk @smithfarm can we update ceph in our CI to be >= 14.2.1 ?

tserong commented 5 years ago

I'm currently asking myself if it is necessary to check Ceph version now because for <= 14.2.0 the config option is server_port and for >= 14.2.1 it will be ssl_server_port

I dunno... Is anyone (aside from our CI :-/) really likely to be using the latest DeepSea with <= 14.2.0?

smithfarm commented 5 years ago

@votdev I tend to agree with @tserong . . . also DeepSea does not (currently) have an explicit "Requires: ceph" in the spec file. I'm not sure it makes sense to add one, either, since that would cause all the ceph RPMs to be installed on the admin node, where they probably wouldn't be needed.

rjfd commented 5 years ago

I don't think we need to check the ceph version. We can assume that this DeepSea code will run with Ceph 14.2.1

smithfarm commented 5 years ago

@susebot run teuthology

susebot commented 5 years ago

Commit 1364b6819165919fe943786c3203a6729af487f5 is OK for suite deepsea:tier2. Check tests results in the Jenkins job: http://storage-ci.suse.de:8080/job/pr-deepsea/201/