fix(makefile): remove hardcoded user:group

SUSE / DeepSea

A collection of Salt files for deploying, managing and automating Ceph.

GNU General Public License v3.0

161 stars 75 forks source link

fix(makefile): remove hardcoded user:group #1696

Closed noelmcloughlin closed 5 years ago

noelmcloughlin commented 5 years ago

Fixes #

Description:

This PR changes hardcoded salt:salt string to dynamic variable.

Checklist:

[ n ] Added unittests and or functional tests
[ n ] Adapted documentation
[ n ] Referenced issues or internal bugtracker
[ y ] Ran integration tests successfully (trigger with "@susebot run teuthology" in a GitHub comment; see the wiki for more information)

tserong commented 5 years ago

Test failures are unrelated

jschmid1 commented 5 years ago

@noelmcloughlin please rebase atop the latest master to make the tests work

noelmcloughlin commented 5 years ago

Done @jschmid1

jschmid1 commented 5 years ago

that rebase added more than it should, mh @noelmcloughlin ?

noelmcloughlin commented 5 years ago

Fixed this time. Let's get this merged soon ;-)

smithfarm commented 5 years ago

This is just a style nit - I try to avoid using the word "fix" in commit titles, since it doesn't really mean anything - if the commit is not fixing something, why have it at all?

So instead of "fix(makefile):" I would start the commit title simply with "Makefile:"

But I'm not saying that with the intention of blocking this PR - the code change looks fine.

noelmcloughlin commented 5 years ago

I try to avoid using the word "fix" in commit titles, since it doesn't really mean anything - if the commit is not fixing something, why have it at all

This is habit of mine in case semantic-release is used. I'd rather leave commit message alone but take your point.