The disk_led runner crashes (bsc#1142821)

votdev commented 5 years ago

Check the result type of 'udev.links' before iterating.
Check if the identifier is in 'grains.get disks' before iterating over the device names (including all the other stuff). This will reduce the work to do in some cases.

Signed-off-by: Volker Theile vtheile@suse.com

Checklist:

[x] Added unittests and or functional tests
[ ] Adapted documentation
[x] Referenced issues or internal bugtracker
[ ] Ran integration tests successfully (trigger with "@susebot run teuthology" in a GitHub comment; see the wiki for more information)

votdev commented 5 years ago

@susebot run teuthology

susebot commented 5 years ago

Commit ac13878c57e4c887004e7a91a2c0b8437d68cddb is NOT OK for suite deepsea:tier2. Check tests results in the Jenkins job: http://ci.ses.suse.de:8080/job/pr-deepsea/252/

SUSE / DeepSea