search

SUSE / DeepSea

A collection of Salt files for deploying, managing and automating Ceph.
GNU General Public License v3.0
161 stars 75 forks source link

remove/replace: add path to status report for better identification #1715

Closed jschmid1 closed 5 years ago

jschmid1 commented 5 years ago

Signed-off-by: Joshua Schmid jschmid@suse.de

before:

salt-run osd.remove(replace) $osd_id [..snip..] 

14:                                                                                                                                                                                                                                            
    True

after:

14:                                                                                                                                                                                      
    ----------                                                                                                                                                                                                                                 
    path:                                                                                                                                                                                                                                      
        /dev/vdb                                                                                                                                                                                                                               
    returncode:                                                                                                                                                                                                                                
        True

suse_internal: bnc#1142663

Checklist: ~- [ ] Added unittests and or functional tests~ ~- [ ] Adapted documentation~ ~- [ ] Referenced issues or internal bugtracker~

jschmid1 commented 5 years ago

@susebot run teuthology

swiftgist commented 5 years ago

Is this for bnc#1142663? It's the request for the model and serial number.

jschmid1 commented 5 years ago

Is this for bnc#1142663? It's the request for the model and serial number.

You're right. I wasn't aware that there is a bug for this. Adding to the PR body.

susebot commented 5 years ago

Commit 623f14c5766cc7c7f00d7ec0ae6f9ce9549f79ad is NOT OK for suite deepsea:tier2. Check tests results in the Jenkins job: http://ci.ses.suse.de:8080/job/pr-deepsea/255/

tserong commented 5 years ago

Shouldn't this then print the model and serial number in addition to the device path?

jschmid1 commented 5 years ago

Shouldn't this then print the model and serial number in addition to the device path?

while the user could technically retrieve this by searching for the device path, this would probably save some time :+1:

In a perfect world we should even hook a disk.led call to a replace/remove call. Would that be useful right now?

tserong commented 5 years ago

In a perfect world we should even hook a disk.led call to a replace/remove call. Would that be useful right now?

Maybe? Although I'm kinda inclined to leave that until someone explicitly asks for it to happen automatically :-)

jschmid1 commented 5 years ago

In a perfect world we should even hook a disk.led call to a replace/remove call. Would that be useful right now?

Maybe? Although I'm kinda inclined to leave that until someone explicitly asks for it to happen automatically :-)

adapted the return to:

serial is postponed until present in ceph-volume inventory json output, as discussed.

jschmid1 commented 5 years ago

Added a fix dc5e1ef for a bug that was introduced with #1690