ganesha: don't run the upgrade on fresh nodes

SUSE / DeepSea

A collection of Salt files for deploying, managing and automating Ceph.

GNU General Public License v3.0

161 stars 75 forks source link

ganesha: don't run the upgrade on fresh nodes #1741

Closed rjfd closed 5 years ago

rjfd commented 5 years ago

Signed-off-by: Ricardo Dias rdias@suse.com

Fixes: bsc#1148405

Description:

Checklist:

[ ] Added unittests and or functional tests
[ ] Adapted documentation
[ ] Referenced issues or internal bugtracker
[ ] Ran integration tests successfully (trigger with "@susebot run teuthology" in a GitHub comment; see the wiki for more information)

jschmid1 commented 5 years ago

I'd assume this is somehow tested by the upgrade tests.. Can you confirm this @smithfarm ?

rjfd commented 5 years ago

@jschmid1 I've manually tested the upgrade as well.

smithfarm commented 5 years ago

@jschmid Which upgrade tests are you referring to? There is a SES5 -> 6 upgrade test that is currently a WIP, and that will (at the very least) do a basic ganesha deployment on SES5 and check its sanity post-upgrade.

jschmid1 commented 5 years ago

@jschmid Which upgrade tests are you referring to? There is a SES5 -> 6 upgrade test that is currently a WIP, and that will (at the very least) do a basic ganesha deployment on SES5 and check its sanity post-upgrade.

@smithfarm In that case I'm referring to that upgrade test :). Would it be possible to run the test on this branch?

smithfarm commented 5 years ago

@jschmid I don't think it's ready for prime time.

jschmid commented 5 years ago

Please "@" the correct user ;)

@jschmid https://github.com/jschmid I don't think it's ready for prime time.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/SUSE/DeepSea/pull/1741?email_source=notifications&email_token=AAEMFWH3YB2IZ62RM4QWWLDQJH6TXA5CNFSM4IU3J23KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6REO3Y#issuecomment-530728815, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEMFWFHA5LQ64XXF64ODCTQJH6TXANCNFSM4IU3J23A .

jschmid1 commented 5 years ago

@jschmid I don't think it's ready for prime time.

I think we did run it from time to time in the past, right?

jschmid1 commented 5 years ago

This needs rebasing now :/ @rjfd

I'd like to have this verified automatically.. rebasing causes issues :)

rjfd commented 5 years ago

retest this please

rjfd commented 5 years ago

rebase done, all checks passed