search

SUSE / DeepSea

A collection of Salt files for deploying, managing and automating Ceph.
GNU General Public License v3.0
161 stars 75 forks source link

Zap disks in rebuild.node when there are no partitions #1887

Closed 0xavi0 closed 2 years ago

0xavi0 commented 2 years ago

Doing this to zap the partition table, as there are issues deploying OSDs with GPT partition tables after rebuilding the nodes.

Signed-off-by: Xavi Garcia xavi.garcia@suse.com

Fixes https://bugzilla.suse.com/show_bug.cgi?id=1194807

There is a problem when zapping partitions that are part of a disk with GPT partition table. Deepsea is zapping the partition but not the whole disk, so the partition table remains and doesn't allow the later deployment of the OSD in SES6.

This is mainly happening for clusters upgraded from SES5, with non-lvm disks.

tserong commented 2 years ago

Minor point of style - can you please put "Fixes: https://bugzilla.suse.com/show_bug.cgi?id=1194807" in the commit message, just above the Signed-off-by: line? See e.g. https://github.com/SUSE/DeepSea/commit/1168b856 (git commit --amend ; git push --force should take care of it)

0xavi0 commented 2 years ago

Commit message updated, thanks Tim