search

SUSE / lrbd

GNU Lesser General Public License v2.1
24 stars 19 forks source link

Refactor for pypi packaging #17

Open hemna opened 6 years ago

hemna commented 6 years ago

This patch refactors the lrbd codebase and makes it installable as a pypi package.

Refactored the lrbd file into the lrbd directory: main.py - the main() with arguments host.py - all the host related methods/classes runtime.py - the Runtime object content.py - all the content related classes utils.py - all the utility functions

Also reworked the unit tests and fixed a lot of hidden failures. The old nosetest runs were hiding a lot of failures that were exposed when you run the test_* files individually.

Implemented a tox based unit test run syste and pep8 violations checks.

tox -epy33 to run all the python 3 based unit tests tox -epep8 to run the pep8 violations checks

ddiss commented 6 years ago

@hemna Thanks a lot for your work on this. As someone unfamiliar with pypi packaging, it certainly looks like a nice logical split of the single source file. My only issue would be that it's difficult to review as a single commit. It'd be great if @swiftgist could share his thoughts.