search

SUSE / minibroker-integration-tests

Apache License 2.0
2 stars 4 forks source link

On tests failure, mits leaves a rabitmq helm release installed #24

Closed viccuad closed 4 years ago

viccuad commented 4 years ago

Hello,

On test failure of rabitmq (https://concourse.suse.dev/teams/main/pipelines/cap-pre-release-caasp/jobs/minibroker-integration-tests-diego-caasp4-sa/builds/1), and after removing minibroker (on catapult, when cleaning the cluster for re-using it), there is still a leftover rabitmq helm release:

$ helm ls -n minibroker
NAME                            NAMESPACE       REVISION        UPDATED                                         STATUS          CHART                                APP VERSION                                                                                                           

rabbitmq-b8b2c81118f53b161762   minibroker      1               2020-10-08 07:52:56.258334748 +0000 UTC         deployed        rabbitmq-6.18.2                      3.8.2

For now I have resorted to a helm ls -n minibroker --short | xargs -L1 helm delete -n minibroker as part of catapult's cleaning step, to clean all helm releases in minibroker namespace. This way clusters can be reused.

Opening this issue for tracking purposes.

Edit: failing test is [Fail] RabbitMQ Without overrideParams set [It] should deploy and connect WITH extra provisioning parameters, from a timeout:

• Failure [369.892 seconds]
 RabbitMQ
 /minibroker-integration-tests/mits/rabbitmq_test.go:27
   Without overrideParams set
   /minibroker-integration-tests/mits/rabbitmq_test.go:34
     should deploy and connect WITH extra provisioning parameters [It]
     /minibroker-integration-tests/mits/rabbitmq_test.go:41

     Unexpected error:
         <*errors.errorString | 0xc0002903f0>: {
             s: "failed to wait for service instance: timed out",
         }
         failed to wait for service instance: timed out
     occurred
     /minibroker-integration-tests/mits/cases.go:77
f0rmiga commented 4 years ago

This is a bug on Minibroker, not MITS. More specifically, it's stated in the OSBAPI: https://github.com/openservicebrokerapi/servicebroker/blob/master/spec.md#deprovisioning.

If a Service Broker accepts the request to delete a Service Instance during the process of it being provisioned, then it MUST have the net effect of halting the current creation process and beginning the deletion of any resources associated with the Service Instance.

f0rmiga commented 4 years ago

Filed https://github.com/kubernetes-sigs/minibroker/issues/114.