Check access for repositories or registry for LTSS

[jesusbv]

Description

If the system is hybrid, it means is PAYG with an add on product (extension) activated. If instance metadata verification succeeded for that system, we check that the registration code is still valid.

• https://trello.com/c/D09lCvMp
• https://confluence.suse.com/display/publiccloud/LTSS+support+for+PAYG+instances

How to test

Running zypper ref or a zypper command on a hybrid system (PAYG with an add-on product activated) with a expired subscription should show access denied message

Change Type

Please select the correct option.

• [ ] Bug Fix (a non-breaking change which fixes an issue)
• [X] New Feature (a non-breaking change which adds new functionality)
• [ ] Documentation Update (a change which only updates documentation)

Checklist

Please check off each item if the requirement is met.

• [X] I have reviewed my own code and believe that it's ready for an external review.
• [X] I have provided comments for any hard-to-understand code.
• [ ] I have documented the MANUAL.md file with any changes to the user experience.
• [ ] If my changes are non-trivial, I have added a changelog entry to notify users at package/obs/rmt-server.changes.

Review

Please check out our review guidelines and get in touch with the author to get a shared understanding of the change.

[jesusbv]

The addition seems to be verbatim a duplication of content used further down the same method. Instead of duplicating the code, let's refactor it into it's own method and just call that twice under different circumstances.

Yep, that's why I converted it to draft, few more things to do but still good to start the review process