FIXED: pwp finding index.pwp and directory handling

SWI-Prolog / packages-http

The SWI-Prolog HTTP server and client libraries

23 stars 23 forks source link

FIXED: pwp finding index.pwp and directory handling #117

Closed erlanger closed 6 years ago

erlanger commented 6 years ago

The logic to find index.pwp stopped working because absolute_file_name/3 only works with files unless file_type(directory) is specified as an option.
This patch fixes the problem and closes SWI-Prolog/swipl-devel#345

JanWielemaker commented 6 years ago

Thanks

The second patch doesn't really do the job correctly either because absolute_file_name/2 doesn't start a search and may thus return a file that doesn't satisfy the conditions although such a file exists. Changed into two absolute_file/3 calls, using file_errors(fail) for the first. Not tested as PWP is not in the test suite ...

Please close if it works for you.

erlanger commented 6 years ago

Thanks @JanWielemaker This works great. I may be able to submit a few simple test cases for PWP, can you point me to a test case that I can use as a starting point?

JanWielemaker commented 6 years ago

Test files are all called test_*.pl and have an entry point that is the name of the file without extension, which should succeed for the test to succeed. Most entry points call a plunit suite. If you peek at a few you'll get the idea. Than they are invoked from Makefile[.in], now being migrated to CMakeLists.txt