SaDiablo / GenshinCompanion

App designed to help you keep track of how things progress in your Genshin Impact adventure
MIT License
2 stars 0 forks source link

[A request to add a new feature] Blocking the addition of the same input again #7

Open marciniuk opened 3 years ago

marciniuk commented 3 years ago

It would be nice if the program blocked the addition of such input that is already in the database. It is also possible that it crashes when we exceed the 90 wishy number without drawing 5* item, but I haven't tested it because it's too big log cleaning.

SaDiablo commented 3 years ago

Allowing items being already there is by design, as if you draw 10pull there can be situation like this:

image And this perfectly valid outcome

If you need you can manually delete single wish from list by pressing right mouse button and Remove I was thinking about adding some visual grouping to the 10pulls in the future

Also i couldn't reproduce the problem with exceeding 90 wishes without 5 drop - it's simply showing negative numbers and stops showing 5 Rate which allows people to store above real wish limits (for example to quickly calculate character rates to their total by adding dummy wishes or some other creative ways of using it). image

If you want to test it don't worry about overriding your existing data - saving wishes is manual only :)

marciniuk commented 3 years ago

How about "locking" the draw, for example, so that you can add up to 9x in a row of 3-star elements?

SaDiablo commented 3 years ago

Good idea, I'm gonna consider adding it as a part of a validity checks in future. For now I'm trying to rebuild this app in AvaloniaUI - if you wanna see progress check Action artifacts, as I'm open for suggestions :D