search

Safehaven-io / ThorBlock

Pooling Service on the Vechain Enterprise blockchain usable for Charity, Crowdfunding and ICO funding/pooling
2 stars 0 forks source link

Do not generated the page before the "has already a wallet?" check #29

Open karelstriegel opened 5 years ago

karelstriegel commented 5 years ago

When thorblock gets permission to access arkane the user is send back to thorblock, then a check is performed to see if the user already has a linked wallet, if not he is again redirected to arkane. In this case the thorblock page is already build and the user briefly sees an error. A better implementation could be to perform the check and if needed the redirect, before the page in build.

image

wijzijnwolf commented 5 years ago

The wallet check was performed in PHP using the API. On the dashboard page it now uses the arkaneConnect.getWallets call

The my wallets page still uses the php api call though (but by the time you navigate there, you should have a wallet already)

I haven't tested the above with a new account yet.