Incorrect rider offset - Githubissues

Saibot393 / Rideable

A Foundry VTT module which allows Tokens to be ridden

MIT License

8 stars 3 forks source link

Incorrect rider offset #80

Closed LordCracken closed 4 months ago

LordCracken commented 4 months ago

Hello. I installed Rideable on Foundry v12 on a DnD 4 system. Mounting goes well. If you control the rider as a GM, the rider and horse are controlled as they should. If you control the rider as a player, the horse moves, but the rider is constantly thrown somewhere. The problem is definitely not in the browser. What could be the problem? Could this be a module bug?

Saibot393 commented 4 months ago

Could you send me screenshot of the ridden tokens rideable settings and of the players rideable client settings?

LordCracken commented 4 months ago

The problem only exists if the GM is not looking at the table tab (but he is online).

LordCracken commented 4 months ago

Could you send me screenshot of the ridden tokens rideable settings and of the players rideable client settings?

Yes, a few minutes

Saibot393 commented 4 months ago

What exactly do you mean with looking at the table tab?

LordCracken commented 4 months ago

Could you send me screenshot of the ridden tokens rideable settings and of the players rideable client settings?

LordCracken commented 4 months ago

What exactly do you mean with looking at the table tab?

I installed Foundry on a remote server and open it through a browser. If the Foundry tab is the current for the GM, there are no problems. If the GM switches to another program, for example, players will have a strange time moving the rider

Saibot393 commented 4 months ago

Ah, ok. For rideable to work a DM has to be online and active (many automations modules of this kind will require this). The problem is that rideable basically allows players to do things that core foundry normally doesn't, so going through the gm is the only way to "overwrite" this. It seems like the browser you are using (btw. which browser are you using) is a bit agressiv with pausing tabs. If i am right, there is probably not much i can do since an active GM is inherent for rideable to work, sorry. There is however still a small chance that there might be a different reason for that behaviour, are there any errors when moving the rider either in the players of the GMs console (F12)?

LordCracken commented 4 months ago

Thank you for your answer. I used Google Chrome (for GM) and Mozilla Firefox Developer Edition (for Player). The GM account was online anyway but the GM not always had the Foundry tab active.

When I turned both browsers in window mode everything worked fine. If I return Firefox in fullscreen mode the problem had returned.

LordCracken commented 4 months ago

are there any errors when moving the rider either in the players of the GMs console (F12)?

Error: You are accessing TokenDocument#actorData which has been migrated to TokenDocument#delta Deprecated since Version 11 Backwards-compatible support will be removed in Version 13

Not sure if this applies to Rideable

Saibot393 commented 4 months ago

Might be related to rideable but should not have any relevance for this bug. If that is the only error/warning in the console, then i fear that it is really a browser related problem, i.e. the browser freezes the tab. I can sadly not really do anything about that, sorry.

LordCracken commented 4 months ago

Thanks again for your answer. At least I was able to understand what actions lead to the problem and how to avoid it.