search

SaitoTech / saito-lite-rust

a version of the Saito-Lite client written for compatibility with the Saito Rust client and binary data format
24 stars 28 forks source link

Cannot send parts of a Saito #2260

Open arpee opened 9 months ago

arpee commented 9 months ago

Sending decimal amount's of Saito does now work. The following error is seen in the sidebar:

Image

I am not sure if this problem goes deeper than the UI, but it looks like sends are in Saito not in nolan, but the underlying data store is an int. This needs to be rectified.

Either do everything in SAITO as a float, or do everything in Nolan and convert in the UI.

arpee commented 9 months ago

Sanka can you provide guidance on this?

SankaD commented 9 months ago

Everything has to be in nolans (bigint) and can be displayed as saito(bigint or number) when required

umairkhannn commented 9 months ago

Tried sending 500 saito as nolan. But getting error from rust. Rust is showing balance in saito, and my nolan balance is exceeding it.

image

umairkhannn commented 9 months ago

Added 5,000,00,000 SAITO to my publickey in issuance file and then sending 2,00,000,000 nolans (2 SAITO). No issue with big amount.

umairkhannn commented 9 months ago

@SankaD created ticket for rust side of issue related to this. https://github.com/SaitoTech/saito-rust-workspace/issues/633

arpee commented 9 months ago

@umair_khannn

Quick update — we have "unmerged" the saito_to_nolan branch from staging. We have done this so that the code in staging will not break the network if we need to update it to prod in an emergency. So please continue the work below in the saito_to_nolan branch. We will merge it only when completed.

These two tasks should be your priorities:

  1. please confirm that token transfers are working properly. This means that when you give yourself NOLAN in the issuance file and send SAITO on-chain the amount of tokens in the transactions are correct (you need to confirm this using the blockchain explorer) and also that amount of tokens that end up in both sender and receiver wallets (use Account > Debug) are also correct.

You should test this using a variety of transactions. Some should send "0.5" SAITO. And some should send integers. And some should send "garbage-text" that isn't a number at all and shouldn't be accepted if submitted. Our first goal is making sure that wallets can send-and-receive tokens properly and that updating sendPayment() fixes these issues.

Once we can confirm that wallets can send tokens correctly, it is highly likely that we will have issues with our UI components displaying NOLAN instead of SAITO. I want to talk to you about this problem and how we should solve it tomorrow morning. But before we do that, I would like you to try and find out how bad the problem is.

So please as your #2 priority look into this problem and finding out how bad it is. Take screenshots. Find out how the in-browser wallet displays SAITO. Please also look at how the in-game crypto menu components look (i.e. Poker). Ideally you can take screenshots showing where the UI is broken. Our goal is to have a list of things that we can check after we fix the problem so that we know we have fixed the problem in all of the places where we display SAITO.

Once I am back online tomorrow morning (for me), I'd like to talk to you about the best way for us to fix any UI display issues. I've spent a bit of time and can see some inconsistencies between how SAITO and WEB3 cryptos have their balances returned and formatted. I would like to get an update from you first on how bad the display problems are and where they are before we talk about this though.