Salam-Labs / Salam-App-Issues

7 stars 0 forks source link

Design suggestions + couple of minor design bugs #24

Closed itzmk21 closed 2 years ago

itzmk21 commented 2 years ago

The modals for example, for Madhab selection, should have more padding, in the inner box, and should have more rounded corners, as most cards in the app do. Some modals have perfect padding but some do not. However rounded corners I think is necessary for these.

Also, for the modals, there should be an OK button, that dismissed the dialog. It is far more intuitive to click a button that says OK than clicking on a different area of the screen or using the back button on an Android phone.

The outline for the current Salah time in the Prayer Times module, is green. However I would like to suggest it be similar to the theme, so for example the Rashidun Caliphate theme, the outline for the active Salah time, should be some shade of maroon.

The way the App transitions to different pages of the App should be changed. Sliding across the different pages, can be laggy on some devices (it is a mobile app after all), and just not quick enough. Once you click on an item on the navbar, the page should either slide or jump straight to the desired page.

The rippling effect on page transitions of the navbar indicators are a bit clunky only for 1 reason: the effect is activated on-press of clicked indicator, however the effect is also activated whilst each page slides through, on each of the page's indicator. This might be a design feature, but the bug is that, the desired page's indicator effect is activated again, so in total twice: at the beginning, and after the other indicator's doing their animation.

In the Prayer Times page, the time for each prayer should have a slightly smaller font, as it seems like there is no space between the numbers and the card itself.

I don't know if this was left intentionally, but, when clicking on the arrows for the date, the on-press kind of glowing effect, can be seen only behind the solid colour backdrop, so it's like a half half circle.

In the compass page, the flag (mine is the UK) and the button that says "Change" aren't aligned. They both start at the same Y coord but the word "Change" is a bit longer than the length of the flag.

The threshold of the compass indicator when turning green and vibrating seems too much. I am a bit too much to the left/right of the Ka'ba picture, and it vibrates too soon.

I feel like the Asma Al-Husna module's text should be a similar font to the rest of the app, for the description of each specific name.

Perhaps a Mushaf module? :)

In the Settings page, in the "Basic Settings" card, there should be more space between the title of the card and the content of the card. The margin and padding of the rest of the cards in this page are perfect. Furthermore the space between the theme name and the same card itself seems too close.

itzmk21 commented 2 years ago

too much? :sweat_smile: