search

Salandora / SophisticatedBackpacks

Sophisticated backpacks is yet another minecraft backpack mod this time with backpack you can place in world, color in different color combinations, upgrade with more inventory and enhance with many functional upgrades.
https://www.curseforge.com/minecraft/mc-mods/sophisticated-backpacks-unofficial-fabric-port
GNU General Public License v3.0
20 stars 6 forks source link

Server crashes upon player death #19

Closed mkern1200 closed 5 months ago

mkern1200 commented 6 months ago

Describe the bug We're using this mod in our modpack on my server. After the update today, we installed it, but two players have died since, and both instances immediately caused our server to crash. One of the players attempted to re-join when the server restarted, but this caused it to crash again, citing an "Exception Ticking World". The crash reports mention Trinkets, so there may be some incompatibility there. We also have the Gravestones mod installed, which may be related to the issue. Crash reports are attached.

To Reproduce Steps to reproduce the behavior:

  1. Install the modpack listed in the "Mods List.txt" file (attached) on a server
  2. Open the world, and give a player the backpack.
  3. Kill the player.
  4. Server crashes upon player death, and that player's attempts to re-join.

Expected behavior Expected that the player would die and the backpack and other items in their inventory would be placed into the gravestone.

Versions Using Fabric Loader 0.15.11, and all mods are included in the "Mods List.txt" file attached.

Mods List.txt

1st-crash.txt 2nd-crash.txt 3rd-crash.txt

littlebugkate commented 6 months ago

I ran into this same problem last night on my single player world, with a similar crash log. I am also using trinkets and gravestones. I've done a little bit of testing, and found out:

  1. The game always crashes on death if I have a backpack in the trinket slot.
  2. The game always crashes on death if I have gravestone drop type to put_in_inventory.

If I have the backpack in my inventory slots, and the gravestone drop type as drop_items, it crashes sometimes but not every time. I haven't figured out why it doesn't always work. The gravestone mod doesn't seem to have the best support for trinkets, as my trinket items were falling on the ground rather than staying in the gravestone. It only crashes with the equipped backpack.

I think I'm going to switch to the gravestone datapack on vanilla tweaks. It's not perfect either, as you don't lose the stuff in your trinket slots upon death, but there's no accidental deletion or crashing.

Salandora commented 6 months ago

Working on a fix for that. Have an idea what is causing it.

Salandora commented 6 months ago

Also interesting you two are talking about 2 different gravestone mods I think. @littlebugkate can you link the one you used?

littlebugkate commented 6 months ago

@Salandora oh shit u right, I didn't look at op's mod list close enough. I was using gravestones by geometrically. sorry about that!

Shadowbee27 commented 6 months ago

With the mod You are in Grave danger the game doesn´t crash when a player is killed.

Salandora commented 6 months ago

Fixed in f6072fbf7151a6d19c3d4ab933fc841696573644

mkern1200 commented 6 months ago

Thank you! Everyone on my server (and myself) has been looking forward to adding this mod since we heard there was a Fabric port. We're very grateful for your efforts!

Salandora commented 5 months ago

Bugfix release is out.