search

Salandora / octoprint-customControl

This plugin makes Custom Controls editable through the OctoPrint WebUI
GNU Affero General Public License v3.0
26 stars 15 forks source link

This plugin seems to be abandoned? If so, let's finally find it a new maintainer! #42

Open foosel opened 2 years ago

foosel commented 2 years ago

Hey @Salandora! This plugin has been in dire need of seeing some rather severe bug (#32, #39) fixed for a while now (first reported in May 2020), for which @jneilliii even provided a bugfix (PR #34, May 27th 2020), yet the last release predates this by a couple days and is from May 7th 2020, so closing in on two years now.

I get that your priorities have probably shifted, and there's really no harm in that (as I'm pretty sure I already said a bunch of times). But for the sake of the people depending on this plugin I think it's time to face it that this plugin should probably be considered abandoned at that point and see if we can't find a new maintainer for it.

Salandora commented 2 years ago

Yeah sadly I guess I have to agree and accept that.

Mungbeanz commented 2 years ago

@jneilliii implemented a fix. Can we at least make this one the current version? https://github.com/jneilliii/octoprint-customControl/archive/devel.zip

M4xTheMan commented 1 month ago

@Salandora Any chance to merge the PR to fix the disappearing control issue?

foosel commented 1 month ago

FYI, I'm working on building the functionality of this plugin into a bundled plugin in OctoPrint, with plans to ship that with version 1.11.0.

The FileManager has already been bundled as a fork called Upload Manager with some improved functionality and UX (see the latest OctoPrint on Air), the goal is to give the Custom Controls Editor a similar treatment.

M4xTheMan commented 1 month ago

Wow, that would be so nice! Thanks a lot! I was very lazy regarding upgrading Octoprint. I; ve looked into this a while ago but today I've suffered heavily from my missing custom control buttons (tried to start a fast print before getting to work). I'll check out the latest OctoPrint on Air.

edit: For now, I've installed the linked fix and edited the yaml-file with the control stuff from a backup.

Salandora commented 1 month ago

@foosel that's aweseome! sorry I make you so much trouble with rewriting all that stuff to proper code 😅

jneilliii commented 1 month ago

I wouldn't say your code was improper, it just has a very quirky race condition that causes the settings to be overwritten with default settings (no custom controls).

foosel commented 1 month ago

sorry I make you so much trouble with rewriting all that stuff to proper code

There's no reason to be sorry, you did a great job, you helped tons, you created some awesome tooling. Yes, there were some bugs here and there, but that's completely normal, look at my code! I'm just moving and bundling because what you created was so much loved by people that it would be sad to let it die, so consider this a big thumb up 👍 rather than something you need to feel embarrassed about or sorry about causing work or something like that. All good mate! 😊