search

SallaApp / ZATCA

An unofficial package maintained by Salla to help developers to implement ZATCA (Fatoora) QR code easily which required for e-invoicing
MIT License
137 stars 54 forks source link

Allow passing mutliple QROptions #10

Closed ali-alharthi closed 2 years ago

ali-alharthi commented 2 years ago

I have seen #7 which is great 👍🏼 However, it would be more efficient passing all the options according to the user needs (since QROptions has multiple options). Also, this allows the user to utilize any added features to the chillerlan\QRCode package in the future 💡

An example for scale would be:

$displayQRCodeAsBase64 = GenerateQrCode::fromArray([
.....
])->render(['scale' => 3]);

PS. Thanks for this simple yet elegant solution .. you saved a lot of time for many developers including myself ❤️

salkhwlani commented 2 years ago

@ali-alharthi thanks, this will introduce a brack change, will be released under v2.0

ali-alharthi commented 2 years ago

@salkhwlani understandable 👍🏼

salkhwlani commented 2 years ago

@ali-alharthi https://github.com/SallaApp/ZATCA/releases