search

Samantha-Mcguigan / my_page

first created repository for my personal website
1 stars 0 forks source link

HTML Feedback #2

Open RJP43 opened 7 years ago

RJP43 commented 7 years ago

@Samantha-Mcguigan

The following are @ahunker 's and my comments on your submission for HTML Exercise 1:

We are really happy to see that you have successfully added an index page to your personal PSC space and pushed it to this GitHub repo. Well done! It looks like you have already got a good start on HTML Exercise 2 and your site has changed significantly since we first looked at it and wrote up some comments.

Our initial comments were encouraging you to add links and mess with your CSS to adjust the size and placement of your image, but since you have already changed all of that I am going to comment on what I can see now on your site.

Great job getting a server side include working on your site! I noticed your updated page looks similar to your sister's personal web space and I wanted to say it is perfectly acceptable to share code as long as you find ways to adjust it and make it your own. I like how you have done to better customize your page to your taste. @ahunker and I both really liked your original background color (#FAEBD7) and you might consider reverting back to that color to further differentiate your page from your sister's. See if you can further mess with the styling on your Study Abroad page to get your images and text sitting more cohesively in that space. Also, it looks like you have a lot of padding at the top and bottom of your text blocks on both pages so you might try messing with that more to see if you can better monopolize that space.

Finally, you currently have some broken links on your site (for Resume and Digital Projects) and that is simply because you have not added those pages to your site yet. You might consider just adding a placeholder for now (like a blank page or something like I have for my study abroad page) so that others going to your site know those pages are under development. If you want your Resume page to go to a link (similar to how I have done with my CV) you just need to add a PDF version of your Resume to your web space and have your link point to your filename with a pdf extension.

Great work so far; you can find your grade for HTML Exercise 1 on Courseweb.

RJP43 commented 7 years ago

@Samantha-Mcguigan

The following are @jonhoranic and my comments on your submission for HTML Exercise 2:

The HTML code on each of your pages is well structured and consistent across your numerous internal pages. Your CSS is well crafted and is accomplishing a lot in creating an appealing visual structuring of your site; however, we encourage you to further mess with the relative spacing of your divs and images (notice what happens to your index page content when re-sizing the browser window or viewing on smaller screens), font sizes, and overall padding of your divs that contain text (especially the excess padding surrounding your text on your study abroad page). Of course, there are always little tweaks that can be made. We do really like how you have been able to accomplish a lot even with the minimalistic HTML code because of your extensive CSS configuring. Well done!

Taking a look at your server permissions: sem150_permissions We noticed you have correctly set permissions for owner and group according to our recommendations (except for your README.md file, which we imagine was unintentionally copied over to your server space from your GitHub repo); however, you need to add the read permission for others (as in the world of possible site visitors outside of you and your other Newtonians) on your pages.

Nice work getting a functioning SSI up on your site that you are using across multiple internal pages. One thing to make mention (that we commented on in our feedback above) is that you do still currently have broken links on your site for your Resume page and Digital Projects page. Just as a reminder so you don't forget to fix those in the future.

Overall, we think you have a pretty clear understanding of how to manipulate your HTML and CSS to create a clean and logical personal website. We encourage you to continue messing with this site throughout the semester and after this course ends to improve upon what you have accomplished here for these assignments.

Great work; you can view your grade for HTML Exercise 2 on Courseweb.