search

Sambruk / EgilSCIM

The EGIL SCIM client
GNU Affero General Public License v3.0
4 stars 7 forks source link

Failed SCIM create doesn't use readable id #184

Closed joesiltberg closed 1 year ago

joesiltberg commented 1 year ago

For instance, remove a necessary , between attributes in a JSON template to cause syntax error. This will typicall give something like:

Failed to create object 163cbddb-9fd0-53df-81e4-e022c5dd5c71 of type Employment

Presumably there are similar for "Failed to update" and "Failed to delete".

Also think about other places where we loop over object lists, those may have been missed since get_uid() isn't usually called then.

joesiltberg commented 1 year ago

Another missing place is when we warn about missing school units when generating Employments:

Missing SchoolUnits found while generating Employments: ou=skolenhet1,ou=skolgruppen,dc=kommunen,dc=se, Objects with missing SchoolUnits: Teacher : 88c0f298-8e33-4566-ace7-6e26228a9bc6,