search

SamiPerttu / fundsp

Library for audio processing and synthesis
Apache License 2.0
808 stars 44 forks source link

v0.18.0 breaks WASM compatibility #43

Closed Smona closed 5 months ago

Smona commented 5 months ago

We are considering using fundsp to build an audio engine for a browser-based DAW. v0.17.1 was looking very promising, but when we upgrade to v0.18.0, our build starts to fail with:

  --> /home/smona/.cargo/registry/src/index.crates.io-6f17d22bba15001f/no_denormals-0.1.2/src/lib.rs:24:1
   |
24 | compile_error!("This crate only supports x86, x86_64 and aarch64.");
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Would it be possible to gate usage of no_denormals behind a feature, or otherwise continue supporting the wasm32-unknown-unknown target?

SamiPerttu commented 5 months ago

Hi! Yes, absolutely. I didn't realize it fails to compile on some targets. I removed no_denormals altogether for now and released version 0.18.1.

Smona commented 5 months ago

Wow, that was fast! Seeing this level of support we are very excited to move forward with fundsp and check out the improvements in 0.18. Thank you for the amazing library!!