search

SamirHodzic / ngx-embed-video

Get embed code for embedding youtube/vimeo/dailymotion/* video in websites from URL or ID in Angular 6+.
MIT License
56 stars 41 forks source link

Fix #7 and fix #6 #11

Closed sixtoad closed 6 years ago

sixtoad commented 6 years ago

@SamirHodzic can you review this pull request?

SamirHodzic commented 6 years ago

@sixtoad thanks for PR, not sure that ng-packagr will work with current structure. Will review & test it soon when I catch time.

codyayers commented 6 years ago

@SamirHodzic, could you review this and get it merged so we can use this?

SamirHodzic commented 6 years ago

@codyayers will do this weekend, didn't have time before. Need to check that we won't break it totally.

codyayers commented 6 years ago

It did unfortunately, so more work will be required I’m afraid

sixtoad commented 6 years ago

@codyayers, I checked the component and it was working for me, how did it break the component?, maybe it was the second commit that changes the http library to make the request (I did not check with an example)

ghost commented 6 years ago

Any ETA on this?

sixtoad commented 6 years ago

@SamirHodzic, it needs some changes for Angular 6, but we should have a version that can run on angular 5 before, do you have an estimation when you can review this? Thanks :)

SamirHodzic commented 6 years ago

Sorry, should be fixed by https://github.com/SamirHodzic/ngx-embed-video/pull/16, but seems like we are skipping Angular 5 with this.