search

SamirHodzic / ngx-embed-video

Get embed code for embedding youtube/vimeo/dailymotion/* video in websites from URL or ID in Angular 6+.
MIT License
56 stars 41 forks source link

able to use with angular 6 #16

Closed lordoliver closed 5 years ago

lordoliver commented 5 years ago

update to angular 6 fix rxjs usage fix http-import upgrade typscript increase major version (has to be major, as anguar also upgrade major version)

SamirHodzic commented 5 years ago

Hey @lordoliver, thanks for your PR. This seems promising, but not able atm to test it with this angular version. I'll reopen PR to try to trigger travis (seems bugged).

lordoliver commented 5 years ago

hm, have to use 0.0 version for dev dependencies?

SamirHodzic commented 5 years ago

Looks more like forced node version for travis. Let me check it out quickly.

lordoliver commented 5 years ago

seems like we have to upgrade codalizer. I will look tomorrow

SamirHodzic commented 5 years ago

in .travis.yml node version should be changed to:

node_js:
  - '7'
lordoliver commented 5 years ago

I don't know, why 7, but here you are ;-)

lordoliver commented 5 years ago

I think your build failed because of network errors.

lordoliver commented 5 years ago

anything else now? the build is fine?

diegomtzb commented 5 years ago

Hello. I am trying to deploy to production with angular 6 and still gettting this error. What could I do to check? Thank you very much.