Some Angular 5 / Typescript issues

SamirHodzic / ngx-embed-video

Get embed code for embedding youtube/vimeo/dailymotion/* video in websites from URL or ID in Angular 6+.

MIT License

56 stars 41 forks source link

Some Angular 5 / Typescript issues #5

Closed mwawrusch closed 6 years ago

mwawrusch commented 6 years ago

ERROR in node_modules/ngx-embed-video/src/embed-video.service.ts(205,26): error TS2345: Argument of type 'string' is notassignable to parameter of type 'never'. node_modules/ngx-embed-video/src/embed-video.service.ts(229,5): error TS2322: Type 'null' is not assignable to type 'string'. node_modules/ngx-embed-video/src/embed-video.service.ts(241,5): error TS2322: Type 'null' is not assignable to type 'string'.

SamirHodzic commented 6 years ago

By default angular-cli is not generating tsconfig with strictNullChecks: true. Thanks for pointing this out, fixed per 6e1c0731f49b29ec7a48b10d008e05ebfa6c861d.

mwawrusch commented 6 years ago

thx