search

Samsung / jalangi2

Dynamic analysis framework for JavaScript
Apache License 2.0
435 stars 119 forks source link

Updated scripts for on-the-fly-instrumention to with python3 and latest version of mitmproxy #171

Closed MadhuNimmo closed 2 years ago

msridhar commented 2 years ago

@MadhuNimmo in the future, don't push to the master branch of a fork. Create a new branch for the change, and push to the new branch and create the PR from it.

msridhar commented 2 years ago

@MadhuNimmo please re-request a review from me when all comments have been addressed.

milahu commented 9 months ago

the readme still says that python2 is required. outdated?

https://github.com/Samsung/jalangi2/blob/fef63515086ddd14fa33078b223eddab9014889c/README.md?plain=1#L27

msridhar commented 9 months ago

the readme still says that python2 is required. outdated?

https://github.com/Samsung/jalangi2/blob/fef63515086ddd14fa33078b223eddab9014889c/README.md?plain=1#L27

Yes, out of date. Fixed in https://github.com/Samsung/jalangi2/commit/8a3669eca0486d369437eb73772f881bbdeeba7d.