Samsung / qaboard

Experiment tracker: organize, visualize, compare and share runs. Removes toil from algorithm/performance R&D and tuning.
https://samsung.github.io/qaboard
Apache License 2.0
53 stars 14 forks source link

Nginx Misconfig #83

Open dk4trin opened 1 year ago

dk4trin commented 1 year ago

Hello Team,

In the deploy files there is a bad configuration in the nginx alias where it is possible to perform a traversal path to access files on the server running the QA-Board. An attacker can use this to scour files on the server that could compromise QA-Board users/customers.

For the technique to be applicable, the following conditions must be met:

image

image

From the procedures of the deploy steps I was able to carry out the proof of concept:

git clone https://github.com/Samsung/qaboard.git
cd qaboard

docker-compose pull
docker-compose up -d

Steps to Reproduce

  1. curl "http://localhost:5151/docs../etc/passwd" | head -n 50

image

I apologize if this is of no use to you.

Best Regards, dk4trin.

arthur-flam commented 1 year ago

Thanks a lot for the report! Indeed I can reproduce. I fixed it in our internal repo (by adding a /) and I hope I'll find time to update GitHub too.

There is no security impact is low as far as I can tell:

Best regards, Arthur