Closed FabrizioJordan closed 1 day ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
drifty | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Nov 28, 2024 7:04am |
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
@SaptarshiSarkar12 Thanks for your feedback! I wanted to explain a few things so you know where I’m coming from.
I’m mainly a web developer, so I don’t have much experience with Java or the differences between GUI and CLI tools. What I did with the animation was just a quick fix by adding overflow-hidden to the parent container to stop it from overflowing. I didn’t know the animation was outdated or didn’t match the current project.
That said, I’ve now managed to apply the overflow-hidden in a different way, and the animation no longer gets cut on the left side. If this works for you, let me know, and I’ll adjust the PR to include it. If the animation still needs to be updated or changed, feel free to share the latest version, and I’ll be happy to apply it. Otherwise, I can leave it as is, and you or someone else can handle it later.
For the header (point #2), I already have some ideas to improve it for both Desktop and Mobile, and making the text bold is one of them.
Let me know what you think, and I’ll adjust the PR based on what’s needed.
I also wanted to mention that I’ve been trying to follow the guidelines for the PR and signing the commits properly. I hope everything looks correct now, but if there’s anything I can improve, please let me know so I can fix it.
@FabrizioJordan Apologise for the late reply. I was busy in the weekend.
I’m mainly a web developer, so I don’t have much experience with Java or the differences between GUI and CLI tools. What I did with the animation was just a quick fix by adding overflow-hidden to the parent container to stop it from overflowing. I didn’t know the animation was outdated or didn’t match the current project.
Okay. No issue. We can keep this animation for now. But it still gets cut on the left side. Please check once.
For the header (point https://github.com/SaptarshiSarkar12/Drifty/discussions/2), I already have some ideas to improve it for both Desktop and Mobile, and making the text bold is one of them.
Yeah, we can proceed with those modifications as well. Should you create a new issue for that?
I also wanted to mention that I’ve been trying to follow the guidelines for the PR and signing the commits properly. I hope everything looks correct now, but if there’s anything I can improve, please let me know so I can fix it.
That's great :+1:. I think there's a problem in the signing of commits, I will check once. If it is a false positive, I would remove that rule.
@FabrizioJordan Please fix the following errors:
_PRETTIER
@FabrizioJordan Please fix the following errors:
_PRETTIER
Yeah, we can proceed with those modifications as well. Should you create a new issue for that?
Is not necessary, i will make the changes right now.
That's great 👍. I think there's a problem in the signing of commits, I will check once. If it is a false positive, I would remove that rule.
The error was on my side. I didn’t know that VSCode doesn’t sign my commits automatically.
But it still gets cut on the left side. Please check once.
With the new changes in this PR, the animation is no longer being cut on the left side.
Also, I noticed that the current CSS linter error is from the latest commit in the project, not my commits, and the error still persists. Let me know if there’s anything I should do about it!
@FabrizioJordan Please fix the following errors:
_PRETTIER
Yeah, we can proceed with those modifications as well. Should you create a new issue for that?
Is not necessary, i will make the changes right now.
@FabrizioJordan Okay, the current changes look nice :+1:.
That's great 👍. I think there's a problem in the signing of commits, I will check once. If it is a false positive, I would remove that rule.
The error was on my side. I didn’t know that VSCode doesn’t sign my commits automatically.
It's okay :smile:.
But it still gets cut on the left side. Please check once.
With the new changes in this PR, the animation is no longer being cut on the left side.
Also, I noticed that the current CSS linter error is from the latest commit in the project, not my commits, and the error still persists. Let me know if there’s anything I should do about it!
I applied the fix :smiley: using prettier.
@SaptarshiSarkar12 Thank you for merging! 🚀 I'm glad to have contributed and would be happy to help with the web in the future. (maybe download page)
@SaptarshiSarkar12 Thank you for merging! 🚀
Most Welcome Fabricio :smile:.
I'm glad to have contributed and would be happy to help with the web in the future. (maybe download page)
@FabrizioJordan I loved collaborating with you on this PR :heart:. Would love to see your wonderful work on the download page :upside_down_face:.
Fixes issue
Fixes #720
Changes proposed
These changes improve consistency across the website.
Check List (Check all the applicable boxes)
Screenshots
Home section:
With 2 buttons in header on hover:
Contribute section:
With 2 buttons in header, 3 contributors avatar and fork button on hover:
Demo section:
Normal:
Buttons on hover:
Footer:
Note to reviewers
@SaptarshiSarkar12 please check it. I didn't touch the Releases page because I think an issue is needed for this page alone.
New Features
Incorrectly used padding and margin replaced with flex and gap. Modern and clean designs for buttons and anchors. Minor changes in Footer. Minor changes in Demo section.
Updated styling for a consistent visual experience.
Bug Fixes
Overflow hidden in Main section.
Summary by CodeRabbit
Release Notes
New Features
Improvements
Bug Fixes