SarinaAtkinson-NOAA / SEFSC-ODM-Management-History

A method for generating an analysis-ready version of the Management History Dataset
Other
0 stars 0 forks source link

Factor in time for closure dates #16

Closed SarinaAtkinson-NOAA closed 1 year ago

SarinaAtkinson-NOAA commented 1 year ago

See cluster 306 Gulf red snapper one-time closures. We have several brief reopenings that end at noon. For example, on 11/1/1995 until 11/2/1995 12:00PM. Therefore, the fishery closes again on 11/2/1995 at 12:01 PM, but with our logic only being on dates, we have the next closure starting on 11/3/1995 and we are using the start time of 60 FR 19363 but really it should be a minute after the reopening end time. This is a very minor thing to automate and what we have may be good enough.

For assessment purposes, how would these closures be used? Could we "round" so the dates line up with how these closures are used for analyses?

Automated table: image

Table from working paper: image

SarinaAtkinson-NOAA commented 1 year ago

After DAAS meeting on 1/9/2023 we decided we want to factor in times because for reports we want these tables to be accurate.

Filtering for cases where we have an END_TIME and the STATUS_TYPE is simple - there are 38 records all closures or reopenings. Of those 38 records, its only cluster 306 (Gulf red snapper) where we have a reopening between a closure and we need to adjust the start date and start time. This adjustment only happens in 1995, 2001, and 2002.

For cluster 306 we want the start date = the previous date and the start time = the previous time + 1 minute.

SarinaAtkinson-NOAA commented 1 year ago

Changes made and cluster 306 looks good now! Still need to cherry pick to main

SarinaAtkinson-NOAA commented 1 year ago

Code in main