search

SavandBros / whisper

Whisper chat for me, myself and I
GNU General Public License v3.0
5 stars 0 forks source link

Get messages of rooms that you're not currently viewing #28

Closed AmirSavand closed 6 years ago

AmirSavand commented 6 years ago

@Alir3z4 do you like this?

Alir3z4 commented 6 years ago

You mean joined but not focused on at the moment ?

How do you want to go for implementation ?

AmirSavand commented 6 years ago

Yes joined and not viewing. It's easy, check this out you'll know how I do it: https://github.com/SavandBros/whisper/blob/master/static/assets/app.js#L33

AmirSavand commented 6 years ago

Each Message instance is inside Room.messages and I only show the room user has selected.

If you select a room that you're not joined in yet, you will join (Room.join())

Alir3z4 commented 6 years ago

Just saw the code, the code is great. Awesome work <3

On Mon, May 21, 2018 at 9:59 PM Amir Savand notifications@github.com wrote:

Closed #28 https://github.com/SavandBros/whisper/issues/28 via 151b589 https://github.com/SavandBros/whisper/commit/151b58979b029fa3c4b9ac1889e8d472728fa50f .

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/SavandBros/whisper/issues/28#event-1637696234, or mute the thread https://github.com/notifications/unsubscribe-auth/AAkFCdNajoil94pPk9YJtrAjrRCPLA8cks5t0w6IgaJpZM4UHaTo .