search

Scan-o-Matic / scanomatic

Scanomatic
GNU General Public License v3.0
10 stars 4 forks source link

Default pinning #284

Closed local-minimum closed 6 years ago

local-minimum commented 6 years ago

Make (32, 48) default pinning. Also removed self._scanning_instructions as it wasn't used.

gdetrez commented 6 years ago

The default pining format should probably be a constant somewhere sane instead of buried inside a method. Beside that, I can't really say if this is correct or not, mabye @skymandr has more experience with this code?

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.03%) to 47.809% when pulling 836335c1439f5f2af3cc91d81df1c315d45f1121 on default-pinning into fbae2a32ada09daeb1546bec76e1b7cbac818177 on master.

local-minimum commented 6 years ago

@gdetrez I moved it to a better place, will attempt making an analysis using this, from compilation, having no pinning-instructions

local-minimum commented 6 years ago

It worked! 🍰